feature-skip-preprocess-on-restart - #1761
Merged
sbryngelson merged 7 commits intoAug 30, 2026
Merged
Conversation
…d on restart. This is a preventative measure against deleting all of your restart data.
|
Claude Code Review Head SHA: 1c52a66 Files changed:
Findings:
|
Member
|
lol. check ai comments when you have a chance |
sbryngelson
previously approved these changes
Aug 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents default preprocessing from overwriting restart data.
Changes:
- Detects explicitly requested run targets.
- Skips preprocessing for restart runs by default.
- Documents the behavior and updates documentation linting.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
toolchain/mfc/run/run.py |
Adds restart-aware preprocessing exclusion. |
toolchain/mfc/args.py |
Records explicit target selection. |
toolchain/mfc/lint_docs.py |
Allows the documented target name. |
docs/documentation/case.md |
Documents restart behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1761 +/- ##
=======================================
Coverage 61.67% 61.67%
=======================================
Files 84 84
Lines 21619 21619
Branches 3196 3196
=======================================
Hits 13334 13334
Misses 6093 6093
Partials 2192 2192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sbryngelson
marked this pull request as draft
August 27, 2026 14:19
sbryngelson
marked this pull request as ready for review
August 28, 2026 23:40
sbryngelson
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have deleted valuable restart data one-to-many times because I forget to call
-t simulationon restart. This PR makes the adjustment thatpre_processmust be explicitly called on restart. This still allows one to restart cases with preprocess if they desire to modify patches, but prevents the deletion of all data from the directory because one forgets to set a target.Acknowledgement
PR template credit: junegunn